From 839bef091f72a1ec0067b81657ad04174e738cc6 Mon Sep 17 00:00:00 2001
From: Riyyi <riyyi3@gmail.com>
Date: Sat, 16 Jan 2021 03:22:01 +0100
Subject: [PATCH] Convert dbgln to r-value reference like the callee's to fix
 compiler ambiguous warnings

---
 inferno/src/inferno/application.cpp    | 2 +-
 inferno/src/inferno/log.h              | 4 ++--
 inferno/src/inferno/systems/camera.cpp | 8 ++++----
 inferno/src/inferno/systems/render.cpp | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/inferno/src/inferno/application.cpp b/inferno/src/inferno/application.cpp
index 600ac3d..b937aa5 100644
--- a/inferno/src/inferno/application.cpp
+++ b/inferno/src/inferno/application.cpp
@@ -126,7 +126,7 @@ namespace Inferno {
 		// bordercolor
 		// offse
 
-		while(!m_window->shouldClose()) {
+		while (!m_window->shouldClose()) {
 
 			float time = Time::time();
 			float deltaTime = time - m_lastFrameTime;
diff --git a/inferno/src/inferno/log.h b/inferno/src/inferno/log.h
index 7e6e6d4..d398561 100644
--- a/inferno/src/inferno/log.h
+++ b/inferno/src/inferno/log.h
@@ -104,7 +104,7 @@ namespace Inferno {
 	template<typename T, typename... P>
 	void dbgln(const char* format, T value, P&&... parameters)
 	{
-		dbgln(Log::None, true, format, value, std::forward<P>(parameters)...);
+		dbgln(Log::None, format, value, std::forward<P>(parameters)...);
 	}
 
 	template<typename T, typename... P>
@@ -115,7 +115,7 @@ namespace Inferno {
 
 	// https://en.cppreference.com/w/cpp/language/parameter_pack#Example
 	template<typename T, typename... P>
-	void dbgln(Log type, bool newline, const char* format, T value, const P&... parameters)
+	void dbgln(Log type, bool newline, const char* format, T value, P&&... parameters)
 	{
 		std::string_view view { format };
 
diff --git a/inferno/src/inferno/systems/camera.cpp b/inferno/src/inferno/systems/camera.cpp
index d57f79a..826fb32 100644
--- a/inferno/src/inferno/systems/camera.cpp
+++ b/inferno/src/inferno/systems/camera.cpp
@@ -26,13 +26,13 @@ namespace Inferno {
 	{
 		auto orthoView = m_registry->view<TransformComponent, OrthographicCameraComponment>();
 
-		for(auto&& [entity, transform, orthographic] : orthoView.each()) {
+		for (auto [entity, transform, orthographic] : orthoView.each()) {
 			updateOrthographic(transform, orthographic);
 		}
 
 		auto perspectiveView = m_registry->view<TransformComponent, PerspectiveCameraComponent>();
 
-		for(auto&& [entity, transform, perspective] : perspectiveView.each()) {
+		for (auto [entity, transform, perspective] : perspectiveView.each()) {
 			updatePerspective(transform, perspective);
 		}
 	}
@@ -47,13 +47,13 @@ namespace Inferno {
 	{
 		auto orthoView = m_registry->view<TransformComponent, OrthographicCameraComponment>();
 
-		for(auto&& [entity, transform, orthographic] : orthoView.each()) {
+		for (auto [entity, transform, orthographic] : orthoView.each()) {
 			return orthographic.projection * transform.transform;
 		}
 
 		auto perspectiveView = m_registry->view<TransformComponent, PerspectiveCameraComponent>();
 
-		for(auto&& [entity, transform, perspective] : perspectiveView.each()) {
+		for (auto [entity, transform, perspective] : perspectiveView.each()) {
 			return perspective.projection * transform.transform;
 		}
 
diff --git a/inferno/src/inferno/systems/render.cpp b/inferno/src/inferno/systems/render.cpp
index 88d0792..ccc4ade 100644
--- a/inferno/src/inferno/systems/render.cpp
+++ b/inferno/src/inferno/systems/render.cpp
@@ -23,7 +23,7 @@ namespace Inferno {
 	{
 		auto group = m_registry->group<TransformComponent, SpriteComponent>();
 
-		for(auto&& [entity, transform, sprite] : group.each()) {
+		for (auto [entity, transform, sprite] : group.each()) {
 			Renderer2D::the().drawQuad(transform, sprite.color, sprite.texture);
 		}
 	}