From 272c728e13ba3499023ecc83ed7495a052929310 Mon Sep 17 00:00:00 2001 From: Riyyi Date: Thu, 10 Feb 2022 14:15:57 +0100 Subject: [PATCH] Manager: Use early-exit return style to decrease nesting --- src/package.cpp | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/package.cpp b/src/package.cpp index b1da556..7e7f065 100644 --- a/src/package.cpp +++ b/src/package.cpp @@ -96,7 +96,7 @@ std::optional Package::fetchAurHelper() "trizen", }; - for(const auto& helper : helpers) { + for (const auto& helper : helpers) { if (findDependency(helper)) { return { helper }; } @@ -112,17 +112,16 @@ void Package::installOrAurInstall(InstallType type) std::optional aurHelper; if (type == InstallType::AurInstall) { - if (m_distro == Distro::Arch) { - aurHelper = fetchAurHelper(); - if (!aurHelper.has_value()) { - fprintf(stderr, "\033[31;1mPackage:\033[0m no supported AUR helper found\n"); - return; - } - } - else { + if (m_distro != Distro::Arch) { fprintf(stderr, "\033[31;1mPackage:\033[0m AUR is not supported on this distribution\n"); return; } + + aurHelper = fetchAurHelper(); + if (!aurHelper.has_value()) { + fprintf(stderr, "\033[31;1mPackage:\033[0m no supported AUR helper found\n"); + return; + } } std::string command = "";